Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to configure the location fo the local maven repo #359

Merged
merged 1 commit into from Jan 23, 2019
Merged

Allow to configure the location fo the local maven repo #359

merged 1 commit into from Jan 23, 2019

Conversation

lburgazzoli
Copy link
Contributor

Fixes #358

nicolaferraro
nicolaferraro requested changes Jan 23, 2019
View reviewed changes
pkg/cmd/install.go
@@ -140,6 +142,9 @@ func (o *installCmdOptions) install(cmd *cobra.Command, args []string) error {
}
}
}
if o.localRepository != "" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unneeded check

deploy/platform-cr.yaml
@@ -8,3 +8,4 @@ spec:
build:
camelVersion: "2.23.1"
baseImage: "fabric8/s2i-java:3.0-java8"
localRepository: "/tmp/artifacts/m2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better leaving it blank here and providing a default when initializing the platform. There are platforms that will not be created by kamel install and don't contain this option. Same is for the baseImage and also camelVersion, do they have a sensible default?

When initializing the platform, we may check for empty values and pick them from this resource file. Wdyt?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do agree, what about opening a new issue for the defaults ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, it seems common to other props

@nicolaferraro nicolaferraro merged commit dbc8a6c into apache:master Jan 23, 2019
@lburgazzoli lburgazzoli deleted the github-358 branch January 23, 2019 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaferraro nicolaferraro nicolaferraro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lburgazzoli @nicolaferraro