Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] OLM fresh install test #3593

Merged
merged 1 commit into from
Sep 7, 2022
Merged

[TEST] OLM fresh install test #3593

merged 1 commit into from
Sep 7, 2022

Conversation

bouskaJ
Copy link
Contributor

@bouskaJ bouskaJ commented Aug 31, 2022

Release Note

NONE

@bouskaJ
Copy link
Contributor Author

bouskaJ commented Aug 31, 2022

This test is implemented to check the OLM installation (mainly the correctness of the installed operator image). I am not sure whether it fits to the upgrade test but it's the only workflow with the OLM installation and I don't want to create a new one for this purpose.

Copy link
Contributor

@phantomjinx phantomjinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tadayosi
Copy link
Member

tadayosi commented Sep 2, 2022

This test is implemented to check the OLM installation (mainly the correctness of the installed operator image). I am not sure whether it fits to the upgrade test but it's the only workflow with the OLM installation and I don't want to create a new one for this purpose.

@bouskaJ I wonder why it cannot fit into e2e/namespace/install? Other than the install test suite being already bloated, it seems to be a more proper location.

@bouskaJ
Copy link
Contributor Author

bouskaJ commented Sep 2, 2022

This test is focused on the OLM installation. I can't see the OLM installation step in the install test suite so I assume that it will not work under the install workflow environment.

@tadayosi
Copy link
Member

tadayosi commented Sep 2, 2022

@phantomjinx Doesn't olm test work under e2e/namespace/install? If it only works under e2e/namespace/upgrade maybe we should change the name from 'upgrade' to 'olm'.

@bouskaJ
Copy link
Contributor Author

bouskaJ commented Sep 2, 2022

@phantomjinx Doesn't olm test work under e2e/namespace/install? If it only works under e2e/namespace/upgrade maybe we should change the name from 'upgrade' to 'olm'.

We have two kinds of the test in the upgrade folder

As you can see that is not the OLM only workflow. I don't know how to approach this.

@tadayosi
Copy link
Member

tadayosi commented Sep 5, 2022

OK, and right now OLM is available only under e2e/namespace/upgrade. Let's accept this PR as-is now. We should rename the e2e structure later.

@tadayosi tadayosi merged commit 1af084a into apache:main Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants