Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): promote allow Integration update #3674

Merged
merged 4 commits into from
Oct 3, 2022
Merged

feat(cli): promote allow Integration update #3674

merged 4 commits into from
Oct 3, 2022

Conversation

squakez
Copy link
Contributor

@squakez squakez commented Sep 26, 2022 •
edited
Loading

Closes #3673
Closes #3676

Release Note

feat(cli): promote allow Integration update

tadayosi
tadayosi approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@tadayosi tadayosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment but otherwise looks good.

@squakez squakez mentioned this pull request Sep 27, 2022
Closed
@tadayosi
Copy link
Member

The test is failing:

❌ TestKamelCLIPromote (2m40.82s)
✅ TestKamelCLIPromote/kamelet_binding_dev (15.1s)
✅ TestKamelCLIPromote/kamelet_integration_dev (19.65s)
✅ TestKamelCLIPromote/no_configmap_in_destination (200ms)
✅ TestKamelCLIPromote/no_secret_in_destination (160ms)
✅ TestKamelCLIPromote/plain_integration_dev (1m18.36s)
✅ TestKamelCLIPromote/plain_integration_promotion (9.54s)
❌ TestKamelCLIPromote/plain_integration_promotion_update (150ms)

@squakez squakez added the status/wip Work in progress label Sep 29, 2022
@squakez
Copy link
Contributor Author

squakez commented Sep 29, 2022

Yeah, sorry, I was on PTO. Already identified the problem and working to its resolution.

@squakez squakez mentioned this pull request Sep 29, 2022
Closed
@squakez squakez added kind/feature New feature or request and removed status/wip Work in progress labels Sep 29, 2022
squakez added a commit to squakez/camel-k that referenced this pull request Sep 30, 2022
@squakez
chore(cli): add a promote message
c3e006b 
Closes apache#3674
@squakez squakez force-pushed the feat/promote_cicd branch 3 times, most recently from cf67cee to 8dcb127 Compare September 30, 2022 09:02
@squakez squakez merged commit df59096 into apache:main Oct 3, 2022
@squakez squakez deleted the feat/promote_cicd branch October 3, 2022 07:17
@tadayosi tadayosi added this to the 1.11.0 milestone Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadayosi tadayosi tadayosi approved these changes

Assignees
No one assigned
Labels
kind/feature New feature or request
Projects
None yet
Milestone
1.11.0
Development

Successfully merging this pull request may close these issues.

Add an info after kamel promote Allow continuous deployment for kamel promote
2 participants
@squakez @tadayosi