Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use SIGTERM and SIGINT aware context for bootstrap operations #3691

Merged
merged 1 commit into from
Sep 29, 2022
Merged

fix: Use SIGTERM and SIGINT aware context for bootstrap operations #3691

merged 1 commit into from
Sep 29, 2022

Conversation

astefanutti
Copy link
Member

Release Note

fix: Use SIGTERM and SIGINT aware context for bootstrap operations

@astefanutti astefanutti added the kind/bug Something isn't working label Sep 29, 2022
Copy link
Member

@tadayosi tadayosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but may I ask what kind of issues this could solve?

Also, should we extend the same technique for kamel CLI to simplify handling of SIGTERM/SIGINT, for instance in local_run.go?

@tadayosi tadayosi added this to the 1.11.0 milestone Sep 29, 2022
@astefanutti
Copy link
Member Author

Looks great, but may I ask what kind of issues this could solve?

This fixes graceful termination of the operator pod, whenever it's bootstrapping, either because it has started recently, or the informers are still starting / stuck, and avoids waiting for the termination grace period to expire.

Also, should we extend the same technique for kamel CLI to simplify handling of SIGTERM/SIGINT, for instance in local_run.go?

That's less critical than for the operator IMO, still would be better yes.

@astefanutti astefanutti merged commit 3068da6 into apache:main Sep 29, 2022
@astefanutti astefanutti deleted the pr-432 branch September 29, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants