Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align to Camel-k-runtime 1.15.0 and camel-kamelets 0.9.1 tag #3710

Merged
merged 2 commits into from
Oct 3, 2022

Conversation

oscerd
Copy link
Contributor

@oscerd oscerd commented Oct 3, 2022

This is for early checking errors. I already noticed errors in tracing trait and other tests.

@oscerd oscerd added this to the 1.10.1 milestone Oct 3, 2022
@oscerd
Copy link
Contributor Author

oscerd commented Oct 3, 2022

Related to #3605

@oscerd
Copy link
Contributor Author

oscerd commented Oct 3, 2022

I thought it would have been a bit more straightforward than this.

@squakez
Copy link
Contributor

squakez commented Oct 3, 2022

I've checked out locally. I think the main reason of all those failures is the fact the project does not build. It seems that if we use the previous camel-k-runtime, it does not fail. I'm looking after it to troubleshoot.

@oscerd
Copy link
Contributor Author

oscerd commented Oct 3, 2022

Just fetch and it is building now.

@squakez
Copy link
Contributor

squakez commented Oct 3, 2022

Just fetch and it is building now.

It wasn't either. The problem was that the unit test required the catalog generated by the runtime. So, we either have to build it before the test (see 6559074) or to push it manually. Let's see if it builds now and I'll port this change to main as well.

@oscerd
Copy link
Contributor Author

oscerd commented Oct 3, 2022

Just fetch and it is building now.

It wasn't either. The problem was that the unit test required the catalog generated by the runtime. So, we either have to build it before the test (see 6559074) or to push it manually. Let's see if it builds now and I'll port this change to main as well.

I meant I fetch with your commit with build-resources before test and it's working fine now.

@oscerd
Copy link
Contributor Author

oscerd commented Oct 3, 2022

The fail is always the one for native. I think we could merge this, so we are fine and ready to release.

@oscerd oscerd merged commit e7a63e7 into release-1.10.x Oct 3, 2022
@claudio4j claudio4j deleted the prepar-1.10.1 branch May 18, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants