Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Make add-repo and remove-repo compatible with a global operator #3731

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

essobedo
Copy link
Contributor

fixes #3667

Motivation

The subcommand add-repo is not compatible with a global operator as it is now, it should be reviewed to propose a way to use it in case a global operator is used.

Modifications:

  • Add the subcommand remove-repo to be able to remove a repository in order to be able to clean up the Integration Platform used for the e2e test
  • Update the active primary IntegrationPlaform of the namespace when the operator id is not set

Release Note

feat(cli): Make add-repo and remove-repo compatible with a global operator

Copy link
Member

@tadayosi tadayosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change request on the e2e test part.

e2e/global/common/kamelet_test.go Show resolved Hide resolved
e2e/global/common/kamelet_test.go Outdated Show resolved Hide resolved
pkg/cmd/kamelet_add_repo.go Show resolved Hide resolved
@essobedo essobedo force-pushed the 3667/make-add-repo-support-global-operator branch from f0d7ff3 to ec51a87 Compare October 11, 2022 08:12
@essobedo essobedo force-pushed the 3667/make-add-repo-support-global-operator branch from ec51a87 to d1a9a7c Compare October 11, 2022 12:45
@essobedo essobedo force-pushed the 3667/make-add-repo-support-global-operator branch from d1a9a7c to b3bffd7 Compare October 11, 2022 15:24
@tadayosi tadayosi merged commit 5d6829d into main Oct 12, 2022
@essobedo essobedo deleted the 3667/make-add-repo-support-global-operator branch October 12, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The --add-repo switch fails with a global operator
4 participants