Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use jolokia version defined in camel-k-runtime #3754

Merged
merged 1 commit into from
Nov 4, 2022

Conversation

claudio4j
Copy link
Contributor

camel-k-runtime change apache/camel-k-runtime#901

Release Note

NONE

@tadayosi
Copy link
Member

@claudio4j Jolokia tests are failing. It looks like something is going wrong.

❌ TestHealthTrait (10m11.87s)
❌ TestHealthTrait/Readiness_condition_with_stopped_route (10m0.24s)
...
❌ TestJolokiaTrait (10m11.14s)
❌ TestJolokiaTrait/Run_Java_with_Jolokia (10m0.24s)

Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to have this marked as WIP or draft, as it should be working only once we have a fixed release of Camel K runtime.

@squakez squakez added this to the 1.11.0 milestone Oct 20, 2022
@tadayosi
Copy link
Member

Ah yes we need an updated camel-k-runtime to make the tests pass. I forgot it.

@squakez squakez added the status/wip Work in progress label Oct 20, 2022
@claudio4j claudio4j marked this pull request as draft October 20, 2022 11:34
@claudio4j
Copy link
Contributor Author

I set to draft, we have to wait the camel-k-runtime version set in the Makefile.
Thanks for the review.

@squakez
Copy link
Contributor

squakez commented Oct 26, 2022

Hey @claudio4j it would be nice if you could rebase against main. Right now we're building against the latest camel k runtime snapshot, so, we don't need to wait any longer to the end of the release process to validate any feature.

@tadayosi tadayosi marked this pull request as ready for review November 4, 2022 04:04
@squakez squakez removed the status/wip Work in progress label Nov 4, 2022
@squakez squakez merged commit 633614c into apache:main Nov 4, 2022
@squakez
Copy link
Contributor

squakez commented Nov 4, 2022

Really cool to see how we can get an early feedback from camel k runtime snapshot!

@claudio4j claudio4j deleted the jolokia branch November 4, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants