Fix get_catalog.sh when runtime is snapshot

[claudio4j]

When the runtime is SNAPSHOT and uses a snapshot repository the downloaded artifact contains a timestamp which is not recognized when trying to move the file.

Release Note

NONE

[squakez]

I am not sure to understand when this is happening. In theory, we use snapshot only when a staging repository is provided, otherwise we should not use it. The -z $2 check is checking exactly that.

[claudio4j]

When building camel-k and referencing RUNTIME_VERSION=1.15.1-SNAPSHOT the mvn -q dependency:copy command downloads the file as camel-k-catalog-1.15.1-20221020.064800-11-catalog.yaml and the ./script/get_catalog.sh script fails with
mv: cannot stat './script/..//resources/camel-k-catalog-1.15.1-SNAPSHOT-catalog.yaml': No such file or directory
When the user provided a snapshot repo, it fails because the remote file doesn't contain the SNAPSHOT suffix in the file name, but contains the timestamp as camel-k-catalog-1.15.1-20221020.064800-11-catalog.yaml

[squakez]

When building camel-k and referencing RUNTIME_VERSION=1.15.1-SNAPSHOT the mvn -q dependency:copy command downloads the file as camel-k-catalog-1.15.1-20221020.064800-11-catalog.yaml and the ./script/get_catalog.sh script fails with mv: cannot stat './script/..//resources/camel-k-catalog-1.15.1-SNAPSHOT-catalog.yaml': No such file or directory When the user provided a snapshot repo, it fails because the remote file doesn't contain the SNAPSHOT suffix in the file name, but contains the timestamp as camel-k-catalog-1.15.1-20221020.064800-11-catalog.yaml

Just tested locally and it works as expected:

$ mvn -q dependency:copy -Dartifact="org.apache.camel.k:camel-k-catalog:1.12.1-SNAPSHOT:yaml:catalog" -DoutputDirectory=.
$ cat camel-k-catalog-1.12.1-SNAPSHOT-catalog.yaml 
# ---------------------------------------------------------------------------
# Licensed to the Apache Software Foundation (ASF) under one or more
# contributor license agreements.  See the NOTICE file distributed with
...
apiVersion: camel.apache.org/v1
kind: CamelCatalog
metadata:
  name: camel-catalog-1.12.1-snapshot

[claudio4j]

Probably there is already an artifact in $HOME/.m2/repository/org/apache/camel/k/camel-k-catalog/1.12.1-SNAPSHOT/ named with 1.12.1-SNAPSHOT in this case, remove that directory and try again, see the results when using a snapshot version downloaded from apache snapshot repo defined in settings.xml

[INFO] Configured Artifact: org.apache.camel.k:camel-k-catalog:catalog:1.12.1-SNAPSHOT:yaml
Downloading from apache-snapshots: https://repository.apache.org/snapshots/org/apache/camel/k/camel-k-catalog/1.12.1-SNAPSHOT/maven-metadata.xml
Downloaded from apache-snapshots: https://repository.apache.org/snapshots/org/apache/camel/k/camel-k-catalog/1.12.1-SNAPSHOT/maven-metadata.xml (1.0 kB at 750 B/s)
Downloading from apache-snapshots: https://repository.apache.org/snapshots/org/apache/camel/k/camel-k-catalog/1.12.1-SNAPSHOT/camel-k-catalog-1.12.1-20220309.050530-16-catalog.yaml
Downloaded from apache-snapshots: https://repository.apache.org/snapshots/org/apache/camel/k/camel-k-catalog/1.12.1-SNAPSHOT/camel-k-catalog-1.12.1-20220309.050530-16-catalog.yaml (90 kB at 76 kB/s)
[INFO] Copying camel-k-catalog-1.12.1-SNAPSHOT-catalog.yaml to /home/claudio/alphaworks/projects/camel-k/camel-k-catalog-1.12.1-20220309.050530-16-catalog.yaml