Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test) : TestRunAndLog to pass on mac os #3828

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Conversation

u5surf
Copy link
Contributor

@u5surf u5surf commented Nov 19, 2022

Signed-off-by: yugo-horie u5.horie@gmail.com

#3813

We divided the test case each OS.

Release Note

TestRunAndLog to pass both linux and MacOS

Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to run go fmton the resource to apply automatically the code style format.

pkg/util/command_test.go Outdated Show resolved Hide resolved
* Fix: apache#3813

Signed-off-by: yugo-horie <u5.horie@gmail.com>
Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I wonder why that "invalid" check was done...

@squakez squakez added the kind/bug Something isn't working label Nov 28, 2022
@squakez squakez merged commit 03b49ea into apache:main Nov 30, 2022
@squakez
Copy link
Contributor

squakez commented Nov 30, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestRunAndLog refactoring
2 participants