Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed AddDependency in integration_type_support.go to handle default … #389

Merged
merged 1 commit into from Jan 29, 2019

Conversation

valdar
Copy link
Member

@valdar valdar commented Jan 28, 2019

…case instead of discarding.

there was a problem handling --runtime xxx dependencies that got discarded:

        integration.Spec.AddDependency("runtime:" + o.Runtime)
    }```
and
```func (is *IntegrationSpec) AddDependency(dependency string) {
    switch {
    case strings.HasPrefix(dependency, "mvn:"):
        util.StringSliceUniqueAdd(&is.Dependencies, dependency)
    case strings.HasPrefix(dependency, "file:"):
        util.StringSliceUniqueAdd(&is.Dependencies, dependency)
    case strings.HasPrefix(dependency, "camel-"):
        util.StringSliceUniqueAdd(&is.Dependencies, "camel:"+strings.TrimPrefix(dependency, "camel-"))
    }
}```
were not cooping that well together resulting in any `--runtime` option to be discarded.

@nicolaferraro nicolaferraro merged commit 94c9c47 into apache:master Jan 29, 2019
@valdar valdar deleted the addDependencyFix branch January 29, 2019 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants