Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): temporary remove env var #3953

Merged
merged 2 commits into from
Jan 3, 2023
Merged

fix(test): temporary remove env var #3953

merged 2 commits into from
Jan 3, 2023

Conversation

squakez
Copy link
Contributor

@squakez squakez commented Dec 22, 2022

I cannot come up with a better solution. If the execution is sequential, temporary removing the environment variable should be fine.

Close #3952

Release Note

fix(test): temporary remove env var

@squakez squakez added the kind/bug Something isn't working label Dec 22, 2022
@squakez
Copy link
Contributor Author

squakez commented Dec 22, 2022

It's failing with:

GITHUB_TOKEN env var detected, using it for GitHub APIs authentication
  Error: cannot read sources: failed to resolve sources: GET https://api.github.com/gists/e2c3f9a5fd0d9e79b21b04809786f17a: 401 Bad credentials []

I'll check how to remove the env variable at all.

@squakez
Copy link
Contributor Author

squakez commented Dec 23, 2022

This is getting weird... now it fails with rate limit when the var is unset:

  Error: cannot read sources: failed to resolve sources: GET https://api.github.com/gists/e2c3f9a5fd0d9e79b21b04809786f17a: 403 API rate limit exceeded for 40.84.169.240. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.) [rate reset in 19m17s]
      testing.go:1169: test executed panic(nil) or runtime.Goexit: subtest may have called FailNow on a parent test

@squakez
Copy link
Contributor Author

squakez commented Jan 3, 2023

The error was cleared. The actual check failure will clear as well when merging.

@squakez squakez merged commit b2834fc into apache:main Jan 3, 2023
@squakez squakez deleted the fix/3952 branch January 3, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E - TestKamelCLIRun constantly failing after secrets.GITHUB_TOKEN applied
3 participants