Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#3988): Fix flaky E2E test on operator multi tenancy #3990

Merged
merged 1 commit into from
Jan 19, 2023
Merged

fix(#3988): Fix flaky E2E test on operator multi tenancy #3990

merged 1 commit into from
Jan 19, 2023

Conversation

christophd
Copy link
Contributor

  • Fix TestOperatorIDFiltering/Operators_can_handoff_scoped_integrations
  • Just set new operator ID, there is no need to explicitly rebuild the integration
  • Avoid race condition between rebuild command and the operator ID update
  • Due to race conditions the test sometimes failed with concurrent resource modification error

@christophd
fix(apache#3988): Fix flaky E2E test on operator multi tenancy
dfb58d4 
- Fix TestOperatorIDFiltering/Operators_can_handoff_scoped_integrations
- Just set new operator ID, there is no need to explicitly rebuild the integration
- Avoid race condition between rebuild command and the operator ID update
- Due to race conditions the test sometimes failed with concurrent resource modification error
@squakez squakez linked an issue Jan 18, 2023 that may be closed by this pull request
Multi tenancy operator flaky test #3988
Closed
@squakez squakez merged commit 1a6119c into apache:main Jan 19, 2023
@squakez
Copy link
Contributor

squakez commented Jan 19, 2023

Thanks for the fix!

@squakez squakez added the kind/bug Something isn't working label Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscerd oscerd oscerd approved these changes

@squakez squakez squakez approved these changes

Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multi tenancy operator flaky test
3 participants
@christophd @squakez @oscerd