feat(e2e): Set a more reasonable default for gomega eventually's polling interval #4008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing interval apache#3992 This commit set a more reasonable default for gomega inetrnal timeout and poll interval used for e2e testing. The defaults are: - EventuallyTimeout is set to 1s (not changed) - EventuallyPollingInterval is set to 500ms - ConsistentlyDuration is set to 100ms (not changed) - EventuallyPollingInterval is set to 500ms Values can be configured via env vars: - E2E_DEFAULT_EVENTUALLY_TIMEOUT - E2E_DEFAULT_EVENTUALLY_POLLING_INTERVAL - E2E_DEFAULT_CONSISTENTLY_DURATION - E2E_DEFAULT_CONSISTENTLY_POLLING_INTERVAL
lburgazzoli
changed the title
oscerd
approved these changes
Jan 25, 2023
lburgazzoli
commented
Jan 25, 2023
| eventuallyTimeoutEnvVarName = "E2E_DEFAULT_EVENTUALLY_TIMEOUT" | ||
| eventuallyPollingIntervalEnvVarName = "E2E_DEFAULT_EVENTUALLY_POLLING_INTERVAL" | ||
| consistentlyDurationEnvVarName = "E2E_DEFAULT_CONSISTENTLY_DURATION" | ||
| consistentlyPollingIntervalEnvVarName = "E2E_DEFAULT_CONSISTENTLY_POLLING_INTERVAL" |
There was a problem hiding this comment.
Here I have introduced some additional env vars to that mirrors the GOMEGA_ ones, not sure if is the best choice or if it would have been better to re-use the same env vars
squakez
approved these changes
Jan 25, 2023
tadayosi
approved these changes
Jan 25, 2023
Not sure if it would really speed up the build but hopefully it would improve the stability |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3992
This commit set a more reasonable default for gomega inetrnal timeout
and poll interval used for e2e testing.
The defaults are:
Values can be configured via env vars:
Release Note