[camel-kamelets] Issue-1330: Deprecating parameters

[manstis]

apache/camel-kamelets#1330

I added the CRD field as instructed and similar to the JSONSchemaProp structure.

I checked generating the documentation with deprecated property and it is already handled.

Just the validation fails as the CRD schema lacks the property.

There is a generated file that looks as though it should be re-generated (since it handles the JSONSchemaProp structure) however I could not see how to regenerate it. The code comments in other files suggest a make step for generate-deepcopy but that appears to be long gone following refactoring of the repository over the years.

Advice is welcome.

Release Note

NONE

[squakez]

You need to run make generate and add the generated code changes as well.

[oscerd]

please generate the crd files through make generate

[manstis]

Thanks @squakez @oscerd.

IDK the CRDs were generated from the sources.

Done.

[squakez]

You need to align the controller-gen to the version we're using or alternatively, revert those changes that have nothing to deal with the deprecate stuff.

[squakez]

This does not look good. I think you have some controller-gen version in your local environment different than the one we are using.

[manstis]

I did wonder.. fixed (I regenerated with controller-gen@v0.6.1)

[oscerd]

I dont know if it makes sense to bring this down on 1.12.x too, it should be harmless but it's a breaking change.

[manstis]

I dont know if it makes sense to bring this down on 1.12.x too, it should be harmless but it's a breaking change.

Let me know.. it's your call.

[squakez]

I dont know if it makes sense to bring this down on 1.12.x too, it should be harmless but it's a breaking change.

I don't think it's a breaking change as we introduce a parameter which could be optional. Whatever works now in 1.12 will work after the change. Feel free to backport.

[manstis]

@squakez Do you mean release-1.12.x?

I couldn't see a 1.12.x otherwise.

[oscerd]

yes, it's release-1.12.x