Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add garbage collector trait #433

Merged
merged 1 commit into from
Feb 15, 2019
Merged

Add garbage collector trait #433

merged 1 commit into from
Feb 15, 2019

Conversation

astefanutti
Copy link
Member

@astefanutti astefanutti commented Feb 14, 2019

Fixes #211

The current algorithm relies on the discovery API to retrieve all the resources group and kind. That results in a collection that can be a bit slow (a couple of seconds). We may refine that step by white-listing or enlisting types to speed-up the collection duration.

@lburgazzoli
Copy link
Contributor

lburgazzoli commented Feb 14, 2019

I think there may be an issue here because the rest trait creates a config map when the integration is in its initialization phase and the gc runs in deploy phase:

@astefanutti
Copy link
Member Author

Let me get back to work 😄!

@lburgazzoli
Copy link
Contributor

We may introduce a concept of integration revision which gets incremented when the integration is in initialization phase and add labels/annotation to track to which revision resources are linked

@astefanutti
Copy link
Member Author

Agreed. That was plan B, which is now A 😄!

Good news is that we have the integration revision for free thanks to f7714fe, as the activation of the status subresource triggers the metadata.generation field to increment in Kubernetes 1.11+.

@astefanutti
Copy link
Member Author

Updated with the revision (metadata.generation) strategy.

@lburgazzoli lburgazzoli merged commit cc7735d into apache:master Feb 15, 2019
@astefanutti astefanutti deleted the 211 branch February 15, 2019 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants