Add field 'camel-version' to Integration CRD #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Feb 15, 2019
lburgazzoli
force-pushed
the
github-439
branch
from
fd3f332
to
8ca2e47
Compare
lburgazzoli
commented
Feb 15, 2019
| selectors := []string{ | ||
| fmt.Sprintf("camel.apache.org/integration=%s", e.Integration.Name), | ||
| fmt.Sprintf("camel.apache.org/generation,camel.apache.org/generation notin (%d)", e.Integration.GetGeneration()), | ||
| } |
There was a problem hiding this comment.
@astefanutti I had to split the line to fix lint findings, can you check it it is still ok ?
There was a problem hiding this comment.
@lburgazzoli I knew that line was way too long 😉! While we are at it, you could split the second selector as well for consistency. Otherwise LGTM.
astefanutti
reviewed
Feb 15, 2019
| res = append(res, item) | ||
| } | ||
|
|
||
| res = append(res, list.Items...) |
There was a problem hiding this comment.
Thanks. Forgot to update it :(
lburgazzoli
force-pushed
the
github-439
branch
from
8ca2e47
to
f09e132
Compare
lburgazzoli
force-pushed
the
github-439
branch
from
f09e132
to
90c88eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #439