Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize reconciliation loops #459

Merged
merged 1 commit into from
Feb 19, 2019
Merged

Optimize reconciliation loops #459

merged 1 commit into from
Feb 19, 2019

Conversation

astefanutti
Copy link
Member

This filters out events that are not relevant, mostly those triggered by status
subresources updates, at the exception of the status phase changes that are used
to transition resources from one phase to another.

This filters out events that are not relevant, mostly those triggered by status
subresources updates, at the exception of the status phase changes that are used
to transition resources from one phase to another.
@lburgazzoli lburgazzoli added the status/wip Work in progress label Feb 19, 2019
@lburgazzoli
Copy link
Contributor

added wip to merge it later when bump to the next version

@lburgazzoli
Copy link
Contributor

There is a case in which we do update an annotation as a way to wake-up the reconcile look:

https://github.com/apache/camel-k/blob/master/pkg/controller/integrationcontext/build.go#L237-L259

not sure if it is taken into account

@astefanutti
Copy link
Member Author

astefanutti commented Feb 19, 2019

EDIT: Changing the annotations and using the normal endpoint to update the resource will won't increment the generation field so the event won't will be filtered out.

@lburgazzoli
Copy link
Contributor

has this any impact with the resources cleanup ? just asking

@lburgazzoli
Copy link
Contributor

maybe we need to move setting the digest on an annotation to a status field or maybe even update the Phase ?

@astefanutti
Copy link
Member Author

has this any impact with the resources cleanup ? just asking

The clean-up delete older generation resources, so that requires a new generation increment whose event are not filtered. So we should be on the safe side.

@astefanutti
Copy link
Member Author

maybe we need to move setting the digest on an annotation to a status field or maybe even update the Phase ?

I wonder exactly that as I stumbled on that piece of code. I didn't give much though about it but that digest annotation looked a bit off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/wip Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants