Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(trait): Fail IntegrationKit when custom task defined with build strategy routine #4649

Merged
merged 1 commit into from Aug 9, 2023
Merged

feat(trait): Fail IntegrationKit when custom task defined with build strategy routine #4649

merged 1 commit into from Aug 9, 2023

Conversation

gansheer
Copy link
Contributor

@gansheer gansheer commented Aug 4, 2023

Ref #4558

Motivation

Adding a custom task with the builder trait result in an unclear error message and cause.

Description

  • Add an IntegrationKit Status Condition Error when a custom builder task is specified on a integration platform defined with routine build strategy
  • Some refactoring to avoid adding tasks to the pipeline when the error fires (else it results in a panic error later)

Release Note

feat(trait): Fail IntegrationKit when custom task defined with build strategy routine

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

🐫 Thank you for contributing!

Code Coverage Report ✔️ - Coverage unchanged.

squakez
squakez approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks!

pkg/trait/builder.go Outdated Show resolved Hide resolved
@gansheer gansheer force-pushed the feat/4558_custom_task_validation branch from 2efe475 to eac26a2 Compare August 7, 2023 07:47
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

🐫 Thank you for contributing!

Code Coverage Report ✔️ - Coverage unchanged.

@gansheer gansheer force-pushed the feat/4558_custom_task_validation branch from eac26a2 to 62ae573 Compare August 7, 2023 16:17
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

🐫 Thank you for contributing!

Code Coverage Report ✔️ - Coverage unchanged.

@gansheer gansheer force-pushed the feat/4558_custom_task_validation branch from 62ae573 to ffdf59b Compare August 8, 2023 13:29
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2023

🐫 Thank you for contributing!

Code Coverage Report ✔️ - Coverage changed: 39.1% --> 39.2% (Coverage difference: +.1%)

@squakez squakez merged commit 308ca76 into apache:main Aug 9, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squakez squakez squakez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gansheer @squakez