Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use go workspace to configure multimodule dependencies #4673

Closed
wants to merge 1 commit into from
Closed

Use go workspace to configure multimodule dependencies #4673

wants to merge 1 commit into from

Conversation

claudio4j
Copy link
Contributor

Release Note

NONE

@github-actions
Copy link
Contributor

🐫 Thank you for contributing!

Code Coverage Report ✔️ - Coverage unchanged.

squakez
squakez approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There are probably changes required in the release process as well, but we can fix as we found them after merging.

@github-actions
Copy link
Contributor

🐫 Thank you for contributing!

Code Coverage Report ✔️ - Coverage unchanged.

@claudio4j
Copy link
Contributor Author

I will wait for the outcome of the proposal to remove the other modules, so probably there won't be a need to merge this PR.

@github-actions
Copy link
Contributor

🐫 Thank you for contributing!

Code Coverage Report ✔️ - Coverage unchanged.

1 similar comment
@github-actions
Copy link
Contributor

🐫 Thank you for contributing!

Code Coverage Report ✔️ - Coverage unchanged.

@claudio4j
Copy link
Contributor Author

Closed in favor of #4690

@claudio4j claudio4j closed this Aug 28, 2023
@claudio4j claudio4j deleted the fix_gomods branch August 28, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squakez squakez squakez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@claudio4j @squakez