-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(traints): ensure an error is returned to the caller if a catalog cannot be found #472
Conversation
pkg/trait/camel.go
Outdated
@@ -51,6 +55,9 @@ func (t *camelTrait) Apply(e *Environment) error { | |||
if err != nil { | |||
return err | |||
} | |||
if c == nil { | |||
return fmt.Errorf("unable to find catalgo for: %s", version) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
pkg/trait/camel.go
Outdated
@@ -70,6 +77,9 @@ func (t *camelTrait) Apply(e *Environment) error { | |||
if err != nil { | |||
return err | |||
} | |||
if c == nil { | |||
return fmt.Errorf("unable to find catalgo for: %s", version) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
b04b965
to
b8caa46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit continued: you can fix the typo in the commit message ;)
b8caa46
to
398b93c
Compare
No description provided.