Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Use maven repository CLI flag for plugins #4730

Merged
merged 1 commit into from Sep 12, 2023

Conversation

gansheer
Copy link
Contributor

Fixes #4608

Description

Use maven repositories from kamel run --maven-repository command flag also as plugin repository in the generated maven project.

Note: This --maven-repository flag values from run command are not added in the generated settings.xml file but embedded in the pom.xml generated file.
This flag is translated in integration CR as:

spec:
  repositories:
  - https://repository.apache.org/content/groups/snapshots-group@id=apache@snapshots@noreleases

Release Note

fix(cli): Use maven repository CLI flag for plugins

@github-actions
Copy link
Contributor

🐫 Thank you for contributing!

Code Coverage Report ✔️ - Coverage unchanged.

@gansheer gansheer force-pushed the fix/4608_custom_int_plugin_repository branch from 651647b to a9c89fe Compare September 12, 2023 08:27
@github-actions
Copy link
Contributor

🐫 Thank you for contributing!

Code Coverage Report ✔️ - Coverage unchanged.

@squakez squakez merged commit 80ca608 into apache:main Sep 12, 2023
14 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add plugin repository when kamel run --maven-repository
3 participants