Activate Kaniko caching and warm the platform base image #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Feb 21, 2019
lburgazzoli
reviewed
Feb 22, 2019
| if target.Spec.Build.PublishStrategy == v1alpha1.IntegrationPlatformBuildPublishStrategyKaniko { | ||
| // create and warm the Kaniko cache into the Camel K builder volume | ||
| action.L.Info("Warming Kaniko cache...") | ||
| err = warmKanikoCache(ctx, action.client, target) |
There was a problem hiding this comment.
wondering if this warming up could be translate into an additional phase and the warmKanikoCache done in a separate co-routine to avoid blocking the reconcile loop
There was a problem hiding this comment.
Yes, totally make sense! Let me rework that part.
lburgazzoli
approved these changes
Feb 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may want to add a configuration parameter on the platform that would control the cache activation.