Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kamelet - Inject secret in Vaults - AWS Secret Manager #4794

Merged
merged 1 commit into from Oct 5, 2023
Merged

Kamelet - Inject secret in Vaults - AWS Secret Manager #4794

merged 1 commit into from Oct 5, 2023

Conversation

oscerd
Copy link
Contributor

@oscerd oscerd commented Oct 4, 2023

Related to #4743

Release Note

This is a first attempt at implementing the requested feature in AWS Secret Manager

I set this as draft because I need some feedback first @squakez @gansheer

@oscerd oscerd requested a review from squakez October 4, 2023 12:18
@oscerd oscerd marked this pull request as draft October 4, 2023 12:18
squakez
squakez approved these changes Oct 4, 2023
View reviewed changes
addons/vault/aws/aws_secrets_manager.go Outdated Show resolved Hide resolved
gansheer
gansheer reviewed Oct 4, 2023
View reviewed changes
Copy link
Contributor

@gansheer gansheer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing ! If you need more help with my comments don't hesitate to ask.

addons/vault/aws/aws_secrets_manager.go Outdated Show resolved Hide resolved
addons/vault/aws/aws_secrets_manager_test.go Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

🐫 Thank you for contributing! 🐫

Unable to create Coverage Report ⚠️.
Merge conflicts found.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

🐫 Thank you for contributing! 🐫

Unable to create Coverage Report ⚠️.
Merge conflicts found.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

🐫 Thank you for contributing! 🐫

Unable to create Coverage Report ⚠️.
Merge conflicts found.

@oscerd oscerd marked this pull request as ready for review October 5, 2023 09:09
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

🐫 Thank you for contributing!

Code Coverage Report ✔️ - Coverage unchanged.

@gansheer
Copy link
Contributor

gansheer commented Oct 5, 2023

LGTM

@oscerd
Kamelet - Inject secret in Vaults - AWS Secret Manager
c08e961 
Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

🐫 Thank you for contributing!

Code Coverage Report ✔️ - Coverage unchanged.

@oscerd
Copy link
Contributor Author

oscerd commented Oct 5, 2023

The error is not related.

@oscerd oscerd merged commit 09d149a into main Oct 5, 2023
15 of 16 checks passed
@squakez squakez deleted the 4743 branch October 17, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gansheer gansheer gansheer approved these changes

@squakez squakez squakez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oscerd @gansheer @squakez