do not include runtime artefacts in operator image by default #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lburgazzoli
force-pushed
the
no-runtime
branch
from
fad349d
to
b9ee88f
Compare
lburgazzoli
changed the title
oscerd
approved these changes
Feb 24, 2019
|
they should not have any version set but that's what the camel-k-maven-plugin does at the moment, I'm working on that |
lburgazzoli
force-pushed
the
no-runtime
branch
from
b9ee88f
to
943d1ca
Compare
nicolaferraro
approved these changes
Feb 25, 2019
There was a problem hiding this comment.
Sounds ok @lburgazzoli. Which part do you think needs an improvement? All pieces seems clearly separated now.
script/Makefile
Outdated
| BASE_IMAGE := fabric8/s2i-java:3.0-java8 | ||
| LOCAL_REPOSITORY := /tmp/artifacts/m2 | ||
| IMAGE_NAME := docker.io/apache/camel-k | ||
| RELEASE_GIT_BRANCH := upstream |
lburgazzoli
force-pushed
the
no-runtime
branch
from
943d1ca
to
cfde28b
Compare
|
so let see how may thing we'll break |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the dependency between camel-k and camel-k-runtime as well a some re-factoring to the build set-up.
Some work is still needed so I definitively need someone to review and suggest cahnges