fix(e2e): Upgrade helm procedure test #4927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Nov 23, 2023
squakez
approved these changes
Nov 24, 2023
gansheer
force-pushed
the
fix/4923_helm_upgrade_procedure
branch
from
ff40e1e
to
20213e4
Compare
squakez
reviewed
Nov 24, 2023
helm/camel-k/README.md
Outdated
| If you are upgrading the `camel-k` Deployment, you should always use a specific version of the chart and pre-install the CRDS: | ||
|
|
||
| ``` | ||
| $ kubectl replace -k "https://github.com/apache/camel-k/config/crd?ref=vx.y.z" |
There was a problem hiding this comment.
We should use the CRDs contained into the chart for consistency.
There was a problem hiding this comment.
I am not sure about this. The charts also contains the edit cluster role, so it would replacing them be one by one instead of the kustomize replace.
AFAIK the CRDs in the charts should always be identical to the ones in config for one version. Also I wonder if we should improve the sync between both versions if we want consistency, WDYT?
There was a problem hiding this comment.
The procedure (and the test) are now using the chart CRDs files.
gansheer
force-pushed
the
fix/4923_helm_upgrade_procedure
branch
from
aa21346
to
03bea6b
Compare
gansheer
force-pushed
the
fix/4923_helm_upgrade_procedure
branch
from
03bea6b
to
46fcbf5
Compare
This was referenced Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #4923
Add helm upgrade test using manual upgrade of CRDs and update the documentation.
Release Note