Perform garbage collection asynchronously #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Feb 25, 2019
lburgazzoli
reviewed
Feb 25, 2019
pkg/trait/gc.go
Outdated
| selectors := []string{ | ||
| fmt.Sprintf("camel.apache.org/integration=%s", e.Integration.Name), | ||
| "camel.apache.org/generation", | ||
| fmt.Sprintf("camel.apache.org/generation notin (%d)", e.Integration.GetGeneration()), |
There was a problem hiding this comment.
Can't this delete running resources ?
Assuming we are on generation 2: at the time this method runs it could be possible that there is a new generation 3 running which that may get deleted by this method.
Isn't it ?
There was a problem hiding this comment.
Very possible 🤕! I've just added a check that makes sure only older generation resources are deleted. Thanks!
lburgazzoli
approved these changes
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #487