Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#3433): Deprecate platform trait create default option #5170

Merged
merged 1 commit into from Feb 20, 2024

Conversation

christophd
Copy link
Contributor

  • Deprecate option to create default integration platform as part of the trait
  • Option to create default integration platform needs to be explicitly enabled (e.g. with auto=true, create-default=true)
  • Usually platform gets automatically created already as part of the operator installation startup procedure
  • Fix trait documentation

Release Note

fix(#3433): Deprecate platform trait create default option

- Deprecate option to create default integration platform as part of the trait
- Option to create default integration platform needs to be explicitly enabled (e.g. with auto=true, create-default=true)
- Usually platform gets automatically created already as part of the operator installation startup procedure
- Fix trait documentation
@christophd
Copy link
Contributor Author

Fixes #3433

Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should deprecate and eventually remove the trait entirely at this stage.

@christophd
Copy link
Contributor Author

Auto creation of an integration platform is only one aspect of the trait. In addition to that the trait is there to set the integration into "waiting for platform" state. it generally checks that there is an integration platform available for the integration.

@christophd christophd merged commit 82df609 into apache:main Feb 20, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants