Use non-caching client in builds scheduling critical section #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davsclaus
reviewed
Apr 19, 2019
| // Non-caching client to be used whenever caching may cause race conditions, | ||
| // like in the builds scheduling critical section. | ||
| // To be replaced with Manager.GetAPIReader() as soon as it's available, see: | ||
| // https://github.com/kubernetes-sigs/controller-runtime/pull/327 |
There was a problem hiding this comment.
Maybe we can add TODO so we will find this in the future and remember to fix/do this when that k8s is released and we are basing on such k8s version
There was a problem hiding this comment.
That's a good idea. I've just re-pushed it with a TODO.
nicolaferraro
approved these changes
Apr 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.