Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add volume argument to kamel run #640

Merged
merged 2 commits into from
May 3, 2019
Merged

feat: Add volume argument to kamel run #640

merged 2 commits into from
May 3, 2019

Conversation

jamesnetherton
Copy link
Contributor

Relates to #587.

nicolaferraro
nicolaferraro approved these changes Apr 30, 2019
View reviewed changes
Copy link
Member

@nicolaferraro nicolaferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! Do you mind adding some documentation, even mentioning the feature in the main readme?

@jamesnetherton
Copy link
Contributor Author

Sure - I'll add some docs tomorrow.

@jamesnetherton
Copy link
Contributor Author

Added some notes to the README as requested.

@nicolaferraro nicolaferraro merged commit 7a00969 into apache:master May 3, 2019
@jamesnetherton jamesnetherton deleted the run-with-volumes branch May 3, 2019 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaferraro nicolaferraro nicolaferraro approved these changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jamesnetherton @nicolaferraro @oscerd