Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include context traits when looking up for a compatible context #659

Merged
merged 1 commit into from May 14, 2019

Conversation

lburgazzoli
Copy link
Contributor

Fixes #649

Copy link
Member

@nicolaferraro nicolaferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. Traits defined on context may also be used to change the deployment behavior only, so it's not always necessary to exclude mismatching context. But I think it's safer to do so. 👍

@nicolaferraro nicolaferraro merged commit 1dbc74b into apache:master May 14, 2019
@lburgazzoli
Copy link
Contributor Author

This applies to platform and external contexts only, it may be restricted to platform created ones if needed but in any case I think automatic selection should go through the safer path and if needed user can explicit set the context to use.

@lburgazzoli lburgazzoli deleted the github-649-context-traits branch May 14, 2019 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

include context traits when looking up for a compatible context
3 participants