Support for integration configuration #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Sep 14, 2018
| @@ -25,7 +25,7 @@ type ProjectDefinition struct { | |||
| Project Project | |||
| JavaSources map[string]string | |||
| Resources map[string]string | |||
| Env map[string]string | |||
| Env map[string]string // TODO: should we deprecate it ? env are set on deployment | |||
There was a problem hiding this comment.
I'm thinking to a "merge" function, where the configuration at context level is used as base for the configuration at integration level. We can do it when creating the integration, so you're right, this can be removed.
There was a problem hiding this comment.
It is already done, env, properties, configmap and secretes from the required context are are applied to integration's deployment :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i.e.:
configmaps, secrets and properties can be set at context and/or integration level.
Fixes #67
Fixes #65
FIxes #62