Add timeout to maven operations #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolaferraro
requested changes
Jun 25, 2019
| @@ -132,12 +132,20 @@ func (action *initializeAction) Handle(ctx context.Context, ip *v1alpha1.Integra | |||
| if target.Spec.Build.PersistentVolumeClaim == "" { | |||
| target.Spec.Build.PersistentVolumeClaim = target.Name | |||
| } | |||
| if target.Spec.Build.Maven.Timeout.Duration == 0 { | |||
| target.Spec.Build.Maven.Timeout.Duration = 2 * time.Minute | |||
There was a problem hiding this comment.
I know that everything is restarted, but I'd increase this to 5 mins because first run is always slow if you don't have a quick network. Wdyt?
There was a problem hiding this comment.
We can increase it but should be lower than the build timeout imho, i.e. it could be set to 2/3 of the build time ?
There was a problem hiding this comment.
Yeah, I think it's ok if the process is restarted once.. not twice..
There was a problem hiding this comment.
should be fixed now
nicolaferraro
approved these changes
Jun 25, 2019
nicolaferraro
approved these changes
Jun 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #761