Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Route trait does not work if route.auto is set to false #783

Merged
merged 1 commit into from
Jul 1, 2019
Merged

Route trait does not work if route.auto is set to false #783

merged 1 commit into from
Jul 1, 2019

Conversation

lburgazzoli
Copy link
Contributor

Fixes #767

nicolaferraro
nicolaferraro reviewed Jun 28, 2019
View reviewed changes
Copy link
Member

@nicolaferraro nicolaferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this introduces some changes and I'm not able to understand it fully. Maybe we talked about it but.. this technically allows to create a route on a even unrelated custom service defined on another namespace, isn't it?

@lburgazzoli
Copy link
Contributor Author

Yeah, I'm unsure too about the implementation: even if we do allow to set the service name, the service need to be related to the integration being "handled" so I think we should remove the possibility to turn off automatic configuration.

@lburgazzoli lburgazzoli added the status/wip Work in progress label Jun 28, 2019
@lburgazzoli lburgazzoli removed the status/wip Work in progress label Jul 1, 2019
@lburgazzoli
Copy link
Contributor Author

@nicolaferraro ok, changed the impl and removed auto for the trait as it does not make sense

@lburgazzoli lburgazzoli merged commit 4ac6992 into apache:master Jul 1, 2019
@lburgazzoli lburgazzoli deleted the github-767 branch July 1, 2019 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaferraro nicolaferraro nicolaferraro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Route trait does not work if route.auto is set to false
2 participants
@lburgazzoli @nicolaferraro