Refactor controller logic #784
Conversation
lburgazzoli
force-pushed
the
controllers
branch
3 times, most recently
from
2798b38
to
158cc48
Compare
lburgazzoli
force-pushed
the
controllers
branch
7 times, most recently
from
b67c6c6
to
25e7640
Compare
…na recive a logger
|
@astefanutti ready for review |
|
|
||
| target, err = a.Handle(ctx, target) | ||
| if err != nil { | ||
| return reconcile.Result{ |
There was a problem hiding this comment.
Shouldn't that be reconcile.Result{}, err to avoid swallowing the error?
|
|
||
| target, err = a.Handle(ctx, target) | ||
| if err != nil { | ||
| return reconcile.Result{ |
There was a problem hiding this comment.
Shouldn't that be reconcile.Result{}, err to avoid swallowing the error?
|
|
||
| target, err = a.Handle(ctx, target) | ||
| if err != nil { | ||
| return reconcile.Result{ |
There was a problem hiding this comment.
Shouldn't that be reconcile.Result{}, err to avoid swallowing the error?
|
|
||
| target, err = a.Handle(ctx, target) | ||
| if err != nil { | ||
| return reconcile.Result{ |
There was a problem hiding this comment.
Shouldn't that be reconcile.Result{}, err to avoid swallowing the error?
| } | ||
|
|
||
| // Requeue scheduling build so that it re-enters the build working queue | ||
| if instance.Status.Phase == v1alpha1.BuildPhaseScheduling || | ||
| instance.Status.Phase == v1alpha1.BuildPhaseFailed { | ||
| if targetPhase == v1alpha1.BuildPhaseScheduling || targetPhase == v1alpha1.BuildPhaseFailed { |
There was a problem hiding this comment.
targetPhase may be empty if the schedule action returns nil, or possibly, when no action can handle the event, so it may be better to replace it with target.Status.Phase.
| @@ -189,7 +189,7 @@ func (r *ReconcileBuild) Reconcile(request reconcile.Request) (reconcile.Result, | |||
| if err != nil { | |||
| return reconcile.Result{ | |||
| Requeue: true, | |||
There was a problem hiding this comment.
IIRC, error are re-queued by default already.
| @@ -256,7 +256,7 @@ func (r *ReconcileIntegration) Reconcile(request reconcile.Request) (reconcile.R | |||
| if err != nil { | |||
| return reconcile.Result{ | |||
| Requeue: true, | |||
There was a problem hiding this comment.
IIRC, error are re-queued by default already.
| @@ -166,7 +166,7 @@ func (r *ReconcileIntegrationKit) Reconcile(request reconcile.Request) (reconcil | |||
| if err != nil { | |||
| return reconcile.Result{ | |||
| Requeue: true, | |||
There was a problem hiding this comment.
IIRC, error are re-queued by default already.
| @@ -151,7 +151,7 @@ func (r *ReconcileIntegrationPlatform) Reconcile(request reconcile.Request) (rec | |||
| if err != nil { | |||
| return reconcile.Result{ | |||
| Requeue: true, | |||
There was a problem hiding this comment.
IIRC, error are re-queued by default already.
Common actions such as deep-cloning the resource and update
them are now performed by the controller wich results in
clean handlers