Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use error condition when active platform cannot be resolved #816

Merged
merged 1 commit into from
Jul 15, 2019

Conversation

jamesnetherton
Copy link
Contributor

Small follow up on #810.

@lburgazzoli we talked a little about this. If there was an error resolving the active platform, then we are by definition 'waiting for platform'. This change enforces that and if necessary, creates an error condition to explain why we are waiting. E.g:

  status:
    conditions:
    - lastTransitionTime: 2019-07-12T10:08:04Z
      lastUpdateTime: 2019-07-12T10:08:04Z
      message: no active integration platforms found in the namespace
      reason: IntegrationPlatformAvailable
      status: "False"
      type: IntegrationPlatformAvailable
    digest: v9FqdLzzwPOMriNhXst9VMIssvvQ4KFBdbBY9K2v29ps
    phase: Waiting For Platform

This fixes the remaining e2e tests are currently failing.

@lburgazzoli lburgazzoli merged commit fd54ffb into apache:master Jul 15, 2019
@jamesnetherton jamesnetherton deleted the fix-integration-e2e-tests branch July 15, 2019 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants