fix build-pod strategy on kubernetes #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Jul 19, 2019
astefanutti
approved these changes
Jul 19, 2019
pkg/controller/build/schedule_pod.go
Outdated
| if err := action.ensureServiceAccount(ctx, pod); err != nil { | ||
| return nil, errors.Wrap(err, "cannot ensure service account is present") | ||
| } | ||
| // Otherwise, let's create the build pod |
There was a problem hiding this comment.
I'd suggest to remove that line has it has moved out of context.
| } | ||
|
|
||
| pod, err := getBuilderPod(ctx, action.client, build) | ||
| if err != nil || pod != nil { |
There was a problem hiding this comment.
It'd be useful to add a comment that we return and wait until the next delete event for the build pod to be de-queued.
lburgazzoli
force-pushed
the
build-pod-strategy
branch
from
d86ae77
to
2052f54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.