Groovy Rest example fails due to Unable to find loader for language=xml #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscerd
approved these changes
Jul 22, 2019
lburgazzoli
reviewed
Jul 22, 2019
pkg/trait/dependencies.go
Outdated
| @@ -50,7 +50,7 @@ func (t *dependenciesTrait) Apply(e *Environment) error { | |||
| util.StringSliceUniqueAdd(&dependencies, dep) | |||
| } | |||
| } | |||
| for _, s := range e.Integration.Spec.Sources { | |||
| for _, s := range append(e.Integration.Spec.Sources, e.Integration.Status.GeneratedSources...) { | |||
There was a problem hiding this comment.
Not sure about this as it could eventually append GeneratedSources to Sources if the underlying slice has some capacity. There is an utility method Integration.Sources() that should properly combine the two sources
There was a problem hiding this comment.
Thanks @lburgazzoli , fixed.
There was a problem hiding this comment.
there is a lint issue
pkg/trait/dependencies_test.go:171: line is 178 characters
|
I can see this in Travis, but on my laptop 'make lint' command hangs. I will check and fix it asap. |
|
You may need to tweak the lint parameters otherwise the linter will eat up all your memory and cpu, i.e. in travis it runs with: |
|
Thanks, @lburgazzoli, fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #838