fix: Enable proxy server to be configured for Kaniko builds #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesnetherton
force-pushed
the
kaniko-proxy
branch
from
aaab68d
to
3421964
Compare
astefanutti
approved these changes
Aug 13, 2019
|
I wonder whether we should consider adding a parameter to disable Kaniko cache warming if that's too much unreliable. |
oscerd
approved these changes
Aug 13, 2019
|
Yeah we could add an option to disable cache warming. I can raise an issue for it (unless you'd prefer it to be part of this fix). |
|
Let's merge this and create a separate issue for the option to disable Kaniko cache warming. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #899
I also tacked on a small 'fix' for the Kaniko cache pod, because it's almost impossible to reliably install camel-k on Minikube without the cache pod crashing (for me at least).
Release Note