Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strimzi 0.20: Lets test early with Release candidate #581

Closed
oscerd opened this issue Oct 13, 2020 · 9 comments
Closed

Strimzi 0.20: Lets test early with Release candidate #581

oscerd opened this issue Oct 13, 2020 · 9 comments

Comments

@oscerd
Copy link
Contributor

oscerd commented Oct 13, 2020

The first one, is already out. We can do this on camel-master
https://github.com/strimzi/strimzi-kafka-operator/releases/tag/0.20.0-rc1

@orpiske
Copy link
Contributor

orpiske commented Oct 13, 2020

@oscerd if you want, I can prepare this.

@oscerd
Copy link
Contributor Author

oscerd commented Oct 13, 2020

Sure, but I'd like to wait for the final release, so maybe we could have a profile for testing with release candidates? Not sure. This would probably require updating to kafka 2.6.0 too

@orpiske
Copy link
Contributor

orpiske commented Oct 13, 2020

I'm trying the following:

mvn -DskipIntegrationTests=false -Dkafka.version=2.6.0 -Ditest.zookeeper.container.image=strimzi/kafka:0.20.0-rc1-kafka-2.6.0 -Ditest.strimzi.container.image=strimzi/kafka:0.20.0-rc1-kafka-2.6.0 -Dkafka.instance.type=local-strimzi-container clean package verify

@orpiske
Copy link
Contributor

orpiske commented Oct 13, 2020

I am not sure yet if the -Dkafka.version=2.6.0 will actually manage to override the version, but the rest should definitely run the tests against Strimzi 0.20 rc1. I am running a build here and will let you know soon.

@oscerd
Copy link
Contributor Author

oscerd commented Oct 13, 2020

Thanks, sounds good. We can do this and if it works we can create a profile to be enabled with a gh action for example.

@orpiske
Copy link
Contributor

orpiske commented Oct 13, 2020

That sounds like a good plan +1.

@orpiske
Copy link
Contributor

orpiske commented Oct 14, 2020

@oscerd looking at the GH actions, it does not seem to have run. I believe I need to cherry-pick the action into master.

@oscerd
Copy link
Contributor Author

oscerd commented Oct 14, 2020

yes

@orpiske
Copy link
Contributor

orpiske commented Oct 14, 2020

Worked after cherry-picking. Therefore, marking this one as closed.

@orpiske orpiske closed this as completed Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants