chore: remove deprecated code in pre 1.6 releases

[squakez]

Closes #2751

Release Note

chore: remove deprecated code in pre 1.6 releases

[squakez]

Just figured out that, for some reason, when we update the kamelet definition, then, both .flow and .template will be left, causing the failure. Likely the same as openshift-integration/kamelet-catalog#223 (comment)

[squakez]

Issue reported in #2988

[squakez]

Hey @christophd, I think the Yaks test is failing because there is some adjustment to make on Yaks configuration to be able to marshal Kamelets with .spec.template instead .spec.flow. Can you please have a look?

[christophd]

@squakez thanks for taking care of it already

[squakez]

Hey @christophd do you mind having a look at the failing tests? It seems that the new Yaks version is not running as expected, as I see installation failures. Can you suggest is there is some additional change to perform to move to the new version?

[christophd]

@squakez yep, I will take a look

[squakez]

Hey @christophd, I think I know what's going on. So, I tried to replicate this locally and the problem is that we have no 0.9.0-SNAPSHOT image available, which is what the nightly CLI (YAKS 0.9.0-202202081029) would expect to install:

2m41s       Normal    BackOff             pod/yaks-operator-66bdff6848-9d8fl    Back-off pulling image "docker.io/citrusframework/yaks:0.9.0-SNAPSHOT"

I understand that we won't be able to have those tests valid until we have Yaks 0.9.0 available. Do you have any plan to release that version shortly? otherwise we can ignore for now this test in order to proceed with the release. What do you suggest?

[christophd]

@squakez but that is why we are using pinned snapshot version that is released via nightly build. let me check the YAKS installation command in the workflow.

[squakez]

@squakez but that is why we are using pinned snapshot version that is released via nightly build. let me check the YAKS installation command in the workflow.

I know, but it would be okey if we only use the CLI. The operator installation (yaks install) procedure, likely fallback to a -SNAPSHOT suffix which does not exist because it was not officially released. I understand we only release stable images in Yaks as well.

[christophd]

Updated my PRs with --operator-image option on the YAKS install command. I think this is a workaround. The pinned snapshot pre-release YAKS binary must not use -SNAPSHOT operator image version when doing a yaks install. This is a bug in the pre-release binaries.

[christophd]

YAKS install issue tracked in citrusframework/yaks#392

[christophd]

@squakez I have fixed the YAKS installation issues and opened a PR on your branch: squakez#10

if you pull the changes we should see this fixed here, too

[squakez]

I think we're almost done with this. There is one last error with Yaks test. I am not able to understand why it is failing. @christophd do you mind having an expert look?

[squakez]

Test failure related to #3055