Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the noise in verbose flattened BOMs #3702

Closed
jamesnetherton opened this issue Apr 6, 2022 · 4 comments
Closed

Reduce the noise in verbose flattened BOMs #3702

jamesnetherton opened this issue Apr 6, 2022 · 4 comments

Comments

@jamesnetherton
Copy link
Contributor

For me it's becoming a source of confusion / merge conflict pain when the line number comments in the verbose BOMs are constantly being shuffled around.

Is there any value in having the verbose BOMs (or even any of the generated BOMs) checked into git?

If not, maybe we output them to a known location in the target directory so that they can still be inspected if desired.

@ppalaga
Copy link
Contributor

ppalaga commented Apr 8, 2022

After thinking of it again, I'd say the line numbers are not useful at all. What matters are the versions and the origin BOM. Those are much more stable.
Do you think removing the line numbers would reduce enough of the noise?

@jamesnetherton
Copy link
Contributor Author

Do you think removing the line numbers would reduce enough of the noise?

Yeah I think it would help. Lets try and see how it goes.

@ppalaga
Copy link
Contributor

ppalaga commented Apr 11, 2022

I'll also replace the current project's version literal with something like ${project.version}. In that way I hope we can avoid any reduce the number of changes during releases.

@ppalaga ppalaga changed the title Disable verbose flattened BOMs Reduce the noise in verbose flattened BOMs Apr 11, 2022
ppalaga added a commit to ppalaga/camel-quarkus that referenced this issue Apr 11, 2022
ppalaga added a commit to ppalaga/camel-quarkus that referenced this issue Apr 11, 2022
ppalaga added a commit to ppalaga/camel-quarkus that referenced this issue Apr 12, 2022
ppalaga added a commit to ppalaga/camel-quarkus that referenced this issue Apr 22, 2022
jamesnetherton pushed a commit to jboss-fuse/camel-quarkus that referenced this issue Apr 25, 2022
ppalaga added a commit to jboss-fuse/camel-quarkus that referenced this issue May 4, 2022
@jamesnetherton
Copy link
Contributor Author

I think we found an acceptable way forward with this. Much less noise generated since 171483b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants