Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Naming Convention Violation #759

Closed
PengZheng opened this issue Jul 8, 2024 · 0 comments · Fixed by #764
Closed

Naming Convention Violation #759

PengZheng opened this issue Jul 8, 2024 · 0 comments · Fixed by #764
Assignees
@xuzhenbao
Labels
component/event-admin Categorizes an issue or PR relevant to the event admin.

Comments

@PengZheng
Copy link
Contributor

According to our coding conventions:

The value of the service name macro should be the service struct (so without a _t postfix)

But we have #define CELIX_EVENT_ADMIN_SERVICE_NAME "celix.service.event.EventAdmin".
@PengZheng PengZheng added the component/event-admin Categorizes an issue or PR relevant to the event admin. label Jul 8, 2024
@xuzhenbao xuzhenbao mentioned this issue Jul 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xuzhenbao xuzhenbao

Labels
component/event-admin Categorizes an issue or PR relevant to the event admin.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename event admin service name xuzhenbao/celix
2 participants
@PengZheng @xuzhenbao