Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need *.webp type images reader and writer #50

Closed
wants to merge 206 commits into from
Closed

Conversation

changbaishan
Copy link

@changbaishan changbaishan commented Jul 10, 2019

As more and more *.webp type images popping up everywhere, I hope commons imaging will help us to read and write this type of images.

As an example, https://i.guancha.cn/bbs/2019/07/10/20190710110612113 is pretty exciting.

Thanks very much!

kinow and others added 30 commits May 2, 2019 23:37
IMAGING-224: Fix travis build
IMAGING-211: Fix boolean logic to produce correct error for invalid PNG chunk size
Camel case vars "filename" to "fileName".
Camel case vars "filename" to "fileName".

Also, method name getFilename() -> getFileName().
Camel case vars "filename" to "fileName".
Disable clirr report for now (alpha releases)
Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm planning an alpha2 release soon, then for alpha3 (besides the work we need for 1.0 without alpha) it would be great to have webp.

@changbaishan any chance to rebase the PR? There are 206 commits in this pull request (see tab "Commits" on GitHub UI). That needs to be correctly rebased before we can review & discuss the issue.

@changbaishan
Copy link
Author

Is there way I can release myself from this PR? I witnessed wonderful works you did. However, I opened it just to suggest a useful feature. I had no idea of what it actually meant. I still love your software. Just don't want to prolong a mistake.

@kinow
Copy link
Member

kinow commented Jun 2, 2020

Is there way I can release myself from this PR? I witnessed wonderful works you did. However, I opened it just to suggest a useful feature. I had no idea of what it actually meant. I still love your software. Just don't want to prolong a mistake.

Your action got the right reaction then :-) we definitely need a webp parser, and I will create a JIRA issue for that. And it was no mistake at all. Feel free to raise issues, pull requests, etc, for whatever new ideas or bugs you may have.

Cheers
Bruno

@kinow
Copy link
Member

kinow commented Jun 3, 2020

@changbaishan
Copy link
Author

Thanks very much! I really appreciate you and your work. Just that I don't know enough to handle the work. Sorry again. Looking forward to use your new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.