Lang 1482 #448
Closed
Lang 1482 #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…short class names
…ength should result ".." it was throwing exception. Tests are added
pull original master
apache master merged into current branch
verhas
commented
Aug 26, 2019
verhas
commented
Aug 26, 2019
verhas
commented
Aug 26, 2019
| throw rethrow(t); | ||
| } | ||
| }; | ||
| return () -> call(pCallable); |
There was a problem hiding this comment.
The functionality as it was implemented the first hand is already there.
update master on fork
…ache-master # Conflicts: # src/test/java/org/apache/commons/lang3/ClassUtilsTest.java
Conflicts: src/main/java/org/apache/commons/lang3/Functions.java src/test/java/org/apache/commons/lang3/FunctionsTest.java
verhas
commented
Nov 7, 2019
| @@ -414,8 +412,8 @@ public void testAsPredicate() { | |||
| assertNotNull(cause); | |||
| assertTrue(cause instanceof SomeException); | |||
| assertEquals("Odd Invocation: 1", cause.getMessage()); | |||
| // assert that it does not throw exception | |||
| final boolean instance = predicate.test(null); | |||
There was a problem hiding this comment.
assertNotNull() makes no sense on primitive
|
And now all the cleanup, extra JavaDoc is just gone... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mainly code clean up
extra tests that were missing
rethrow now corrects stack trace showing the location where the rethrow was called
(nobody cares that an exception was thrown from a utility function that does nothing else but throws the exception)
documentation was extended