RNG-176: Enhance the UniformRandomProvider interface #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 76dfcb7 into 22bba87 - view on LGTM.com new alerts:
|
Add methods for streams and generation of numbers in a range. The methods match those implementations in JDK 17 RandomGenerator interface. Add default implementations of the existing interface methods using nextLong() as the source of randomness.
|
This pull request introduces 1 alert when merging 9c264dd into c285f7d - view on LGTM.com new alerts:
|
Only one method is required to implement the interface. This simplifies creation of implementations for testing edge cases. For a delegate implementation then additional methods must be added. This applies to RandomSource.unrestorable.
The methods are now present as default implementations in the client-api UniformRandomProvider. This requires JApiCmp is disabled as it does not recognise the change as compatible. Binary compatibility is checked by revapi which allows this change.
|
This pull request introduces 1 alert when merging f3df9db into c285f7d - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.