Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
CB-14108: fix incorrect count in config_munge in ios.json and android.json #24
What does this PR do?
This PR affects the cordova prepare command as follows.
Futrher, adding related test codes. (ConfigError.spec.js, ConfigChanges.spec.js)
What testing has been done on this change?
Before this PR, if we use config.file like
note that count is 1. Again doing
where the count is 2.
This unnatural behavior is fixed by this PR.
@@ Coverage Diff @@ ## master #24 +/- ## ========================================= + Coverage 85.51% 87.1% +1.58% ========================================= Files 19 19 Lines 1761 1830 +69 Branches 371 384 +13 ========================================= + Hits 1506 1594 +88 + Misses 255 236 -19
Thanks for the pull request!
I'm not especially familiar with the config munging code, but I know it has been a source of edge case bugs and particular around multiple plugin.xml/config.xml wanting to make conflicting changes. There are a few open issues in JIRA (CB-13474, CB-13486, and CB-13514 in particular) related to those edge cases, and I wanted to check if you thought your changes will have any impact (positive or negative) on those.
Sorry, CB-13474, CB-13486 and CB-13514 are the issues in which multiple config-files and/or edit-configs compete each other. (I.e. xml conflicting)