New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add method getPodSpecs and add related tests #48

Merged
merged 1 commit into from Nov 1, 2018

Conversation

3 participants
@knight9999
Copy link
Contributor

knight9999 commented Sep 12, 2018

Platforms affected

ios

What does this PR do?

  • Add new method getPodSpecs for PluginInfo class
  • Add test code

See apache/cordova-discuss#108

What testing has been done on this change?

  • npm run test

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Sep 12, 2018

Codecov Report

Merging #48 into master will increase coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   87.82%   87.98%   +0.15%     
==========================================
  Files          19       19              
  Lines        1799     1822      +23     
  Branches      373      377       +4     
==========================================
+ Hits         1580     1603      +23     
  Misses        219      219
Impacted Files Coverage Δ
src/PluginInfo/PluginInfo.js 83.41% <100%> (+2.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c6cda3...e410842. Read the comment docs.

@erisu erisu referenced this pull request Sep 12, 2018

Closed

CocoaPods Improvement #391

@knight9999 knight9999 requested review from stevengill , erisu and dpogue Sep 12, 2018

@janpio janpio added this to 🐣 New PR / Untriaged in Apache Cordova: Tooling Pull Requests Sep 13, 2018

@knight9999 knight9999 force-pushed the cordova-develop:dev_improve_cocoapod_support branch from fc7f5fd to e410842 Sep 21, 2018

@janpio janpio moved this from 🐣 New PR / Untriaged to ⏳ Ready for Review in Apache Cordova: Tooling Pull Requests Sep 24, 2018

@knight9999 knight9999 referenced this pull request Sep 25, 2018

Open

Add podspec #892

0 of 2 tasks complete
@dpogue

dpogue approved these changes Sep 28, 2018

Apache Cordova: Tooling Pull Requests automation moved this from ⏳ Ready for Review to ✅ Approved, waiting for Merge Sep 28, 2018

@dpogue dpogue merged commit be6c0ea into apache:master Nov 1, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Apache Cordova: Tooling Pull Requests automation moved this from ✅ Approved, waiting for Merge to 🏆 Merged, waiting for Release Nov 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment