-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate tests to Jasmine 3 driven by Karma #176
Conversation
On Fri, Sep 21, 2018 at 6:15 AM Raphael von der Grün < ***@***.***> wrote:
This PR does the following:
- Migrate test sources from Jasmine 1 to Jasmine 3 (Closes #140
<#140>)
- Setup tests so they are run by Karma in Headless Chrome against the
build produced by our Grunt task compile
- Remove obsolete Grunt tasks test, cover and all of their
dependencies, thus resolving npm audit warnings (Resolves #171
<#171>)
<3
I will probably need 1-2 days to review formally.
… |
3b8dff3
to
894b8e8
Compare
Co-authored-by: Raphael von der Grün <raphinesse@gmail.com>
Co-authored-by: Raphael von der Grün <raphinesse@gmail.com>
My one minor, non-blocking critique is that
I think this is a sign of something that could be done better in our JavaScript, would like to see this tracked in some kind of an "improvement" issue (assuming this PR is actually merged, which I would favor). I am really happy to see improved test automation and minimal disturbance of @raphinesse please merge! |
This PR does the following:
compile
test
,cover
and all of their dependencies, thus resolvingnpm audit
warnings (Resolves Migrate from jasmine-node to Jasmine 3 #171)