Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate tests to Jasmine 3 driven by Karma #176

Merged
merged 9 commits into from
Oct 25, 2018

Conversation

raphinesse
Copy link
Contributor

@raphinesse raphinesse commented Sep 21, 2018

This PR does the following:

@brodycj
Copy link

brodycj commented Sep 23, 2018 via email

@brodycj
Copy link

brodycj commented Oct 10, 2018

My one minor, non-blocking critique is that npm test (using headless Chrome) outputs the following log message:

LOG: 'Could not find cordova.js script tag. Plugin loading may fail.'

I think this is a sign of something that could be done better in our JavaScript, would like to see this tracked in some kind of an "improvement" issue (assuming this PR is actually merged, which I would favor).

I am really happy to see improved test automation and minimal disturbance of src.

@raphinesse please merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants