Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from jasmine-node to Jasmine 3 #171

Closed
brodycj opened this issue Sep 18, 2018 · 2 comments
Closed

Migrate from jasmine-node to Jasmine 3 #171

brodycj opened this issue Sep 18, 2018 · 2 comments
Assignees

Comments

@brodycj
Copy link

brodycj commented Sep 18, 2018

I picked up maintainer responsibility of jasmine-node as a temporary workaround to resolve npm audit issues before the next major release. Now that we are targeting the next major release I think we should migrate from jasmine-node to Jasmine 3, which I think would need some minor changes to the JavaScript.

@brodycj
Copy link
Author

brodycj commented Sep 18, 2018

PR #140 looks like an attempt to migrate to Jasmine (2) almost 2 years ago, does not seem to be working.

I am thinking it may be easiest to migrate away from Grunt before migrating away from jasmine-node.

@raphinesse raphinesse self-assigned this Sep 19, 2018
@raphinesse
Copy link
Contributor

I have a local branch with tests driven by Karma on Headless Chrome using Jasmine 3. Needs a bit of work still, but I will open a PR as soon as it's ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants