Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-13813: (iOS) Remove old iOS code #381

Merged
merged 1 commit into from
Dec 4, 2018

Conversation

jcesarmobile
Copy link
Member

@jcesarmobile jcesarmobile commented Nov 23, 2018

Platforms affected

iOS

What does this PR do?

It removes iOS 8 checks as cordova-ios only support iOS 9 and newer. (might still be breaking change as won't work on iOS 7?)
Removed the deprecated UIAlertView
Reworked the logic about requesting/checking permissions so it doesn't present the camera picker if the permission is not granted. As side effect of this, also fixes CB-14082, which had another PR that won't be needed

What testing has been done on this change?

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@jcesarmobile jcesarmobile merged commit ce77aab into apache:master Dec 4, 2018
@jcesarmobile jcesarmobile deleted the CB-13813 branch December 4, 2018 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants